Fix tileSize for non-geospatial use-case
#5886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-gold
changed the title
tileSize to utils functions.tileSize for non-geospatial use-case
|
Can you review the Where |
|
@Pessimistress Sounds like a plan. I'll add the documentation for this PR and open another for the new prop then to control the "zoom offset." |
This was referenced Jun 21, 2021
|
Closing in favor of #5895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5811 - this PR solves the problem by basically reverting #4616 for the non-geospatial use-case. As I mentioned, though, the only problem now is that I have come to rely on the ability to change the zoom level at which tiles are fetched in the non-geospatial case.
Should I follow this PR up with another that allows the user to offset the zoom level in the non-geospatial instance? Should this PR not revert the changes from #4616 and just document what people need to do with regards to the
tileSizeprop when they are using theTileLayerin the non-geospatial use-case.Change List